Skip to content

cilium: follow-ups on annotation mode #35224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

cilium: follow-ups on annotation mode #35224

merged 3 commits into from
Oct 7, 2024

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Oct 4, 2024

(see commit desc)

@borkmann
cilium, bpf: Restore skipping the revSNAT path
974128d 
In case of ICMP and BPF masquerading off we can skip the revSNAT path via
CILIUM_CALL_IPV4_NODEPORT_NAT_INGRESS.

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
cilium, bpf: Better naming of svc mode flip
0ee1ade 
Right now in annotation mode we have SNAT by default and DSR via
annotation. The other way round is not supported, thus the naming
is also rather misleading. Thus, state to what we actually do.

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Oct 4, 2024
@borkmann
cilium, complexity: Add xdp tests for annotation mode
fadbd66 
Add XDP-related complexity tests for annotation mode with IPIP.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

borkmann commented Oct 4, 2024

/test

@borkmann borkmann marked this pull request as ready for review October 4, 2024 08:50
@borkmann borkmann requested review from a team as code owners October 4, 2024 08:50
@borkmann
Copy link
Member Author

borkmann commented Oct 4, 2024

( upgrade tests all red due to #35228 )

@borkmann borkmann requested a review from mhofstetter October 4, 2024 11:42
@borkmann
Copy link
Member Author

borkmann commented Oct 4, 2024

/test

@julianwiedmann julianwiedmann added the area/loadbalancing Impacts load-balancing and Kubernetes service implementations label Oct 7, 2024
julianwiedmann
julianwiedmann approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit dcfd2d7 Oct 7, 2024
272 checks passed
@julianwiedmann julianwiedmann deleted the pr/bpf-follow-ups branch October 7, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@mhofstetter mhofstetter Awaiting requested review from mhofstetter

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/loadbalancing Impacts load-balancing and Kubernetes service implementations release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borkmann @jibi @julianwiedmann