Skip to content

README: Update badge for GAPI v1.1.0 #35217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

README: Update badge for GAPI v1.1.0 #35217

merged 1 commit into from
Oct 4, 2024

Conversation

joestringer
Copy link
Member

No description provided.

@joestringer
README: Update for GAPI v1.1.0
3819be8 
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner October 3, 2024 23:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 3, 2024
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Oct 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2024
@joestringer joestringer changed the title README: Update for GAPI v1.1.0 README: Update badge for GAPI v1.1.0 Oct 4, 2024
@joestringer joestringer requested a review from a team October 4, 2024 00:00
@joestringer
Copy link
Member Author

@sayboras oh I see you just posted v1.2.0 support PR at #35216 :D ... what do you think we should do with the badge, update to 1.1.0 since that's the current supported Cilium release or 1.2.0 in your PR since Cilium will soon support 1.2.0?

@sayboras
Copy link
Member

sayboras commented Oct 4, 2024

oh I see you just posted v1.2.0 support PR at #35216 :D ... what do you think we should do with the badge, update to 1.1.0 since that's the current supported Cilium release or 1.2.0 in your PR since Cilium will soon support 1.2.0?

Good catch, I have added the changes to update the badge to v1.2.0 in the PR #35216 as well. Upstream report is pending for review kubernetes-sigs/gateway-api#3372.

sayboras
sayboras approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it, just in case we want to backport to 1.16.

@joestringer joestringer merged commit 25a6dfd into main Oct 4, 2024
56 checks passed
@joestringer joestringer deleted the pr/joe/fix-gapi-badge branch October 4, 2024 02:38
@joestringer
Copy link
Member Author

README is typically only inspected for the main branch so no need to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joestringer @sayboras