Skip to content

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Oct 3, 2024

As BGP instances are identified by name in BGPRouterManager for BGPv2, we should use instance name instead of ASN in DiffStore Diff ID for BGPv2.

@rastislavs rastislavs added release-note/misc This PR makes changes that have no direct user impact. area/bgp Impacts the Border Gateway Protocol feature. labels Oct 3, 2024
@rastislavs
Copy link
Contributor Author

/test

@rastislavs rastislavs marked this pull request as ready for review October 3, 2024 18:56
@rastislavs rastislavs requested a review from a team as a code owner October 3, 2024 18:56
@rastislavs
Copy link
Contributor Author

/test

As BGP instances are identified by name in BGPRouterManager
for BGPv2, we should use instance name instead of ASN
in DiffStore Diff ID for BGPv2.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs
Copy link
Contributor Author

/test

@joestringer joestringer enabled auto-merge October 4, 2024 17:07
@joestringer joestringer added this pull request to the merge queue Oct 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 7, 2024
Merged via the queue into cilium:main with commit f641356 Oct 7, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants