Policy: fix ToServices performance regression #35293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marseel
reviewed
Oct 8, 2024
It turns out that ForEachService() does a lot of allocation to convert an EndpointSlices in to an Endpoints; this is wasteful if the caller does not need the endpoints. Instead, yield the EndpointSlices directly, so the caller may generate the endpoints if desired. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
We already track whether or not a given CNP / CCNP has a ToServices selector. We can use this bit to skip resolving ToServices entirely (and thus iterating over all known services) when no ToServices selectors are present. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
af57bf7 to
7a9dc08
Compare
|
/test |
marseel
approved these changes
Oct 10, 2024
tommyp1ckles
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
1: Make service iteration more efficient. It turns out that calling
eps.Endpoints()is very allocation-heavy. Before this change, it was called for every service when iterating, which was unnecessary. Instead, leave this to the caller, who can do so only when necessary2: Skip policy ToServices translation when policy has no ToServices selectors. We already track whether or not policies have a ToServices selector. When one does not, we do not need to try and translate services.
Fixes: #35273