Skip to content

ci: conformance-kind: don't explicitly enable session affinity #35290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

ci: conformance-kind: don't explicitly enable session affinity #35290

merged 1 commit into from
Oct 8, 2024

Conversation

julianwiedmann
Copy link
Member

This option is already implied by KPR=true.

@julianwiedmann
ci: conformance-kind: don't explicitly enable session affinity
fca7b20 
This option is already implied by KPR=true.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels Oct 8, 2024
@julianwiedmann
Copy link
Member Author

@brb mind keeping me honest here? For reference.

@julianwiedmann julianwiedmann added the dont-merge/waiting-for-review Requires further review before merging. label Oct 8, 2024
@julianwiedmann julianwiedmann marked this pull request as ready for review October 8, 2024 09:03
@julianwiedmann julianwiedmann requested review from a team as code owners October 8, 2024 09:03
@julianwiedmann julianwiedmann requested review from aanm and nebril October 8, 2024 09:03
@julianwiedmann
Copy link
Member Author

/test

brb
brb approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Session Affinity is considered part of the full KPR (in kube-proxy there is no need to opt-in for SA).

@julianwiedmann julianwiedmann removed the dont-merge/waiting-for-review Requires further review before merging. label Oct 8, 2024
aanm
aanm approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit b069e30 Oct 8, 2024
73 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/main/ci-conformance-session-affinity branch October 8, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@aanm aanm aanm approved these changes

@nebril nebril Awaiting requested review from nebril nebril is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/loadbalancing Impacts load-balancing and Kubernetes service implementations release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @brb @aanm