Skip to content

Fix upgrade documentation at Helm template generation: "agent: Invalid type. Expected: boolean, given: object" #35288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix upgrade documentation at Helm template generation: "agent: Invalid type. Expected: boolean, given: object" #35288

merged 1 commit into from
Oct 8, 2024

Conversation

oneumyvakin
Copy link
Contributor

@oneumyvakin oneumyvakin commented Oct 8, 2024 •
edited by qmonnet
Loading

Using agent.enabled=false producing the following error:

helm template cilium/cilium   \
   --namespace=kube-system   \
   --set agent.enabled=false \
   --set config.enabled=true \
   --set operator.enabled=false   > cilium-configmap.yaml
coalesce.go:237: warning: skipped value for cilium.agent: Not a table.
Error: values don't meet the specifications of the schema(s) in the following chart(s):
cilium:
- agent: Invalid type. Expected: boolean, given: object

docs: Change invalid Helm option --agent.enabled with --agent=false in upgrade documentation

@oneumyvakin oneumyvakin requested a review from a team as a code owner October 8, 2024 07:28
@oneumyvakin oneumyvakin requested a review from qmonnet October 8, 2024 07:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 8, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 8, 2024
@oneumyvakin @qmonnet
docs: Change invalid Helm option --agent.enabled with --agent=false
9f45c33 
Fix upgrade documentation at Helm template generation, where the
parameter for enabling the agent is no longer correct and produces the
following error:

    "agent: Invalid type. Expected: boolean, given: object"

[ Quentin: Reformat commit object, description ]

Fixes: e9cb43c ("Helm: full refactor of helm charts, default values implemented, tests updated, kind cni integration")
Signed-off-by: Oleg Neumyvakin <oneumyvakin@gmail.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet qmonnet force-pushed the fix-upgrade-doc-agent-object branch from ac7e409 to 9f45c33 Compare October 8, 2024 12:39
qmonnet
qmonnet approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the fix! I simply reworded the commit title and description (you had a long title, and checkpatch has a test to keep it short).

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Oct 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 8, 2024
@qmonnet
Copy link
Member

qmonnet commented Oct 8, 2024

/test

@qmonnet
Copy link
Member

qmonnet commented Oct 8, 2024

Note: checkpatch still fails because of the name and email in the Sign-off-by tag not being identical to the author metadata for the commit, but they're variations for the same author: this is fine to ignore.

@qmonnet qmonnet added needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 8, 2024
@qmonnet qmonnet enabled auto-merge October 8, 2024 12:46
@qmonnet qmonnet added this pull request to the merge queue Oct 8, 2024
Merged via the queue into cilium:main with commit 8639738 Oct 8, 2024
57 of 58 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 8, 2024
@giorio94 giorio94 mentioned this pull request Oct 9, 2024
Merged
5 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 9, 2024
@giorio94 giorio94 mentioned this pull request Oct 9, 2024
Merged
4 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Oct 9, 2024
@giorio94 giorio94 mentioned this pull request Oct 10, 2024
Merged
4 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Oct 10, 2024
@github-actions github-actions bot removed the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label Oct 16, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 16, 2024
This was referenced Nov 13, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oneumyvakin @qmonnet @giorio94