Skip to content

renovate: temporarily do not update GoBGP dependency #35272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

renovate: temporarily do not update GoBGP dependency #35272

merged 1 commit into from
Oct 8, 2024

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Oct 7, 2024 •
edited
Loading

Due to a breaking change in GoBGP v3.30.0, do not update GoBGP dependency until osrg/gobgp#2844 is resolved.

Re-enabling tracked in #35271

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 7, 2024
@rastislavs rastislavs added area/bgp Impacts the Border Gateway Protocol feature. release-note/misc This PR makes changes that have no direct user impact. labels Oct 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 7, 2024
@rastislavs rastislavs force-pushed the gobgp-stop-updating branch from 58490a9 to 21cf3d2 Compare October 7, 2024 12:47
@rastislavs
Copy link
Contributor Author

/test

@rastislavs rastislavs marked this pull request as ready for review October 7, 2024 13:09
@rastislavs rastislavs requested review from a team as code owners October 7, 2024 13:09
@rastislavs rastislavs requested review from aanm and nebril October 7, 2024 13:09
@aanm aanm enabled auto-merge October 7, 2024 14:07
@rastislavs rastislavs force-pushed the gobgp-stop-updating branch from 21cf3d2 to 82caf99 Compare October 8, 2024 06:27
@rastislavs
renovate: temporarily do not update GoBGP
e21fa55 
Due to a breaking change in GoBGP v3.30.0, do not update GoBGP
until osrg/gobgp#2844 is resolved.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs force-pushed the gobgp-stop-updating branch from 82caf99 to e21fa55 Compare October 8, 2024 06:28
@rastislavs
Copy link
Contributor Author

/test

@aanm aanm added this pull request to the merge queue Oct 8, 2024
Merged via the queue into cilium:main with commit 4b9306a Oct 8, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@nebril nebril Awaiting requested review from nebril nebril is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rastislavs @aanm