Skip to content

Conversation

pedroignacio13
Copy link
Contributor

@pedroignacio13 pedroignacio13 commented Oct 7, 2024

Please ensure your pull request adheres to the following guidelines:

The getting started section for the Azure Kubernetes Service was missing a parameter in the command.
Without the "--generate-ssh-keys" parameter is not possible to create the AKS Cluster as shown in the following print:
image
The change included the required parameter for users to be able to create the AKS Cluster.

docs: Add parameter to generate SSH keys for AKS "getting started" steps.

@pedroignacio13 pedroignacio13 requested a review from a team as a code owner October 7, 2024 11:35
@pedroignacio13 pedroignacio13 requested a review from qmonnet October 7, 2024 11:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 7, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 7, 2024
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Oct 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 7, 2024
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

CI was failing because we have a check on the length of the commit title, so I fixed it and force-pushed on your branch.

@qmonnet
Copy link
Member

qmonnet commented Oct 7, 2024

/test
[EDIT Looks like we need a rebase for the tests]

@qmonnet qmonnet enabled auto-merge October 7, 2024 12:01
The getting started section for the Azure Kubernetes Service was missing
a parameter in the command. Without the "--generate-ssh-keys" parameter
is not possible to create the AKS Cluster as shown in the following
print:

    $ az aks create --resource-group "${AZURE_RESOURCE_GROUP}" --name "${NAME}" --network-plugin none
    An RSA key file or key value must be supplied to SSH Key Value. You can use --genertae-ssh-keys to let CLI genertae one for you

[ Quentin: shorten commit object, copy description from PR. ]

Signed-off-by: Pedro Ignacio <pedroig100.pi@gmail.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet
Copy link
Member

qmonnet commented Oct 7, 2024

/test

@qmonnet qmonnet added this pull request to the merge queue Oct 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 7, 2024
Merged via the queue into cilium:main with commit ad0e0e8 Oct 7, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants