helm: Add priorityClass with default system-node-critical to spire co… #35269
Conversation
|
Commit 88e3c6c does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1906c9d to
eb82214
Compare
|
Commit 89ebea6 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1720e66 to
a8e3e50
Compare
5ce51f3 to
7505377
Compare
|
/test |
Addet default priorityClassName system-node-critical to the spiro components and added the capability to overwrite the spiro components priorityClassName Signed-off-by: Tilusch <til.heini@swisscom.com>
|
@gandro I had to force push again due to a long commit subject and missing Doc update. Tests should pass now :) |
|
/test |
|
@gandro Any idea why the E2E Upgrade test is failing? Should not be affected by the changes made to the helmchart. |
|
They are known to be flaky, in this case I think we're hitting #31050 I'll restart them. Sidenote: Please note that pushing to the branch will invalidate CI results. So unless there is a conflict, I'd recommend not updating the branch anymore. |
|
@cilium/sig-servicemesh PTAL |
Currently the Helmchart to install Cilium does not allow to set a priorityClassName to the spire agent or server.
Since those are mission critical component when using cilium service mesh it would be a good practice to set a corresponding priorityClassName.