Skip to content

Refactor and set a default for GH_RUNNER_EXTRA_POWER #35267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Oct 7, 2024

No description provided.

aanm added 2 commits October 7, 2024 13:06
Refactor vars.GH_RUNNER_EXTRA_POWER to vars.GH_RUNNER_EXTRA_POWER_UBUNTU_LATEST
to make it clear that this variable should be pointing to ubuntu-latest.

Signed-off-by: André Martins <andre@cilium.io>
If GH_RUNNER_EXTRA_POWER_UBUNTU_LATEST is not set then the GH workflow
should default to ubuntu-latest to avoid workflows from failing on forks
in case the variable is not set on such fork.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 7, 2024
@aanm aanm requested review from a team as code owners October 7, 2024 11:08
@aanm
Copy link
Member Author

aanm commented Oct 7, 2024

/test

@aanm aanm enabled auto-merge October 7, 2024 11:08
@aanm aanm added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 96f1bc9 Oct 7, 2024
232 checks passed
@aanm aanm deleted the pr/add-different-type-of-vars branch October 7, 2024 14:23
@giorio94 giorio94 mentioned this pull request Oct 9, 2024
5 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 9, 2024
@giorio94 giorio94 mentioned this pull request Oct 9, 2024
4 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Oct 9, 2024
@giorio94 giorio94 mentioned this pull request Oct 10, 2024
4 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Oct 10, 2024
@aanm aanm mentioned this pull request Oct 11, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants