Skip to content

cec: Switch to slog for CEC #35253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

cec: Switch to slog for CEC #35253

merged 1 commit into from
Oct 7, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 6, 2024

No description provided.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 6, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Oct 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 6, 2024
@sayboras sayboras force-pushed the pr/tammach/convert-slog branch from 07eaa16 to 821c54e Compare October 6, 2024 11:10
@sayboras
Copy link
Member Author

sayboras commented Oct 6, 2024

/test

@sayboras
Copy link
Member Author

sayboras commented Oct 6, 2024

/ci-gateway-api

@sayboras
cec: Switch to slog for CEC
84b72ff 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/convert-slog branch from 821c54e to 84b72ff Compare October 6, 2024 11:28
@sayboras
Copy link
Member Author

sayboras commented Oct 6, 2024

/ci-gateway-api

@sayboras
Copy link
Member Author

sayboras commented Oct 6, 2024

/test

@sayboras sayboras marked this pull request as ready for review October 6, 2024 12:38
@sayboras sayboras requested review from a team as code owners October 6, 2024 12:38
mhofstetter
mhofstetter approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayboras sayboras enabled auto-merge October 7, 2024 09:12
qmonnet
qmonnet approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger.Info("Looks good to me, thanks")

@sayboras sayboras added this pull request to the merge queue Oct 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 7, 2024
Merged via the queue into main with commit d91e387 Oct 7, 2024
286 checks passed
@sayboras sayboras deleted the pr/tammach/convert-slog branch October 7, 2024 10:21
@sayboras sayboras mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel marseel approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayboras @marseel @mhofstetter @qmonnet