-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: Add support for impersonation --as and --as-group flags #35240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebril
approved these changes
Oct 7, 2024
nathanjsweet
approved these changes
Oct 8, 2024
giorio94
reviewed
Oct 9, 2024
394be98
to
beaf5be
Compare
giorio94
reviewed
Oct 10, 2024
beaf5be
to
ebb0c99
Compare
giorio94
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/test |
@cnmcavoy it needs a rebase. |
@cnmcavoy It looks like we have some conflicts. Could you take a peek? Thank you! |
Signed-off-by: Cameron McAvoy <cmcavoy@indeed.com>
ebb0c99
to
15b9be4
Compare
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cilium-cli
This PR contains changes related with cilium-cli
cilium-cli-exclusive
This PR only impacts cilium-cli binary
kind/community-contribution
This was a contribution made by a community member.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
We use impersonation as cluster admins to elevate access to customer secrets and certain resources, and kubectl supports this with the --as or --as-group flags. Currently to use the cilium cli tool, we have to hand edit our kubeconfig to add as: for our user, and then remember to remove it afterwords. Supporting impersonation directly in the Cilium cli tooling would make it much safer for us and align cilium with other kubectl flags.
Note: previously implemented and reviewed over in the cilium/cilium-cli: cilium/cilium-cli#2696
Fixes: N/A