Skip to content

Conversation

AdityaK60
Copy link
Contributor

Grammatically updated the documents.

Signed-off-by: Aditya Kumar aditya.kumar60@infosys.com

@AdityaK60 AdityaK60 requested review from a team as code owners October 1, 2024 07:06
@AdityaK60 AdityaK60 requested review from nebril and learnitall October 1, 2024 07:06
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 1, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 1, 2024
Signed-off-by: Aditya Kumar <aditya.kumar60@infosys.com>
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Oct 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2024
@nebril
Copy link
Member

nebril commented Oct 2, 2024

/test

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. We can further improve the docs but this is a step forward.

@@ -70,7 +70,7 @@ Release Cadence
~~~~~~~~~~~~~~~

We aim to make 2 to 3 `point releases`_ per year of Cilium and its core components
(Hubble, Cilium CLI, Tetragon, etc). We also make patch releases available as
(Hubble, Cilium CLI, Tetragon, etc.). We also make patch releases available as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Our docs style actually suggest to avoid latin abbreviations:

https://docs.cilium.io/en/stable/contributing/docs/docsstyle/#don-t-use-latin-abbreviations

@joestringer joestringer enabled auto-merge October 3, 2024 17:22
@joestringer joestringer added this pull request to the merge queue Oct 3, 2024
Merged via the queue into cilium:main with commit be767a1 Oct 3, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants