minor pkg/ip fixes #35130
Merged
minor pkg/ip fixes #35130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely left over from a conversion from checkmate to go testing. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
To create a baseline for the next commit. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
This gives us a speedup of 30% in a microbenchmark for sorting IPs and
moves us closer to stdlib.
pkg: github.com/cilium/cilium/pkg/ip
│ pre │ post │
│ sec/op │ sec/op vs base │
SortAddrList-10 105.06µ ± 4% 72.75µ ± 1% -30.75% (p=0.000 n=10)
Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
23e78a1 to
661d068
Compare
|
/test |
tklauser
reviewed
Oct 1, 2024
tklauser
approved these changes
Oct 1, 2024
The type constraints of slices.Sort and slices.Compact are different - the former requires cmp.Ordered whereas the latter only needs comparable. The only caller for SortedUniqueFunc was pkg/ip, for []netip.Addr. The usage is inefficient, though, since netip.Addr is comparable, just not cmp.Ordered - the use of slices.CompactFunc is thus unnecessary. Since there's no consumers, and use can be needlessly inefficient, let's just drop the function, even though it breaks API symmetry. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
9475d22 to
4606ccb
Compare
ovidiutirla
approved these changes
Oct 1, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small drive-by improvements to
pkg/ip.