Skip to content

hubble: fix drop notify test #35196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

hubble: fix drop notify test #35196

merged 1 commit into from
Oct 3, 2024

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Oct 3, 2024

There was a race between merging d8efde4 and 27e9169.

Fixes: #35059

@rolinh
hubble: fix drop notify test
9f8388a 
There was a race between merging d8efde4 and 27e9169.

fix: 27e9169

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added release-note/misc This PR makes changes that have no direct user impact. sig/hubble labels Oct 3, 2024
@rolinh rolinh requested a review from a team as a code owner October 3, 2024 12:10
@rolinh rolinh mentioned this pull request Oct 3, 2024
Merged
kaworu
kaworu approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! 🙏

@jrajahalme jrajahalme mentioned this pull request Oct 3, 2024
Closed
@gandro gandro mentioned this pull request Oct 3, 2024
Merged
@jrajahalme
Copy link
Member

/test

@rolinh rolinh enabled auto-merge October 3, 2024 12:23
@jrajahalme jrajahalme mentioned this pull request Oct 3, 2024
Merged
@rolinh rolinh added this pull request to the merge queue Oct 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Oct 3, 2024
Merged via the queue into main with commit 21adb31 Oct 3, 2024
267 checks passed
@rolinh rolinh deleted the pr/rolinh/fix-hubble-threefour branch October 3, 2024 15:18
@nathanjsweet nathanjsweet mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolinh @jrajahalme @kaworu