policy: Wait on sync.WaitGroup only after adding to it #35195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
gandro
approved these changes
Oct 3, 2024
Call queueNotifiedUsersCommit() before starting go routing waiting on `wg`, as queueNotifiedUsersCommit() does `wg.Add(1)`. This makes it impossible to hit this bug: ``` 2024-10-03T08:45:07.562242086Z panic: sync: WaitGroup is reused before previous Wait has returned 2024-10-03T08:45:07.562251423Z 2024-10-03T08:45:07.562358242Z goroutine 11033 [running]: 2024-10-03T08:45:07.562532947Z sync.(*WaitGroup).Wait(0xc0041bfe90?) 2024-10-03T08:45:07.562538587Z /usr/local/go/src/sync/waitgroup.go:120 +0x74 2024-10-03T08:45:07.562541644Z github.com/cilium/cilium/pkg/policy.(*SelectorCache).UpdateIdentities.func1(0xc01829a4c0) 2024-10-03T08:45:07.562544629Z /go/src/github.com/cilium/cilium/pkg/policy/selectorcache.go:540 +0x3a 2024-10-03T08:45:07.562547444Z created by github.com/cilium/cilium/pkg/policy.(*SelectorCache).UpdateIdentities in goroutine 357 2024-10-03T08:45:07.562550470Z /go/src/github.com/cilium/cilium/pkg/policy/selectorcache.go:539 +0xd54 ``` Fixes: cilium#34205 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
5976df1 to
f966abf
Compare
|
Rebased to get integration test fix. |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
queueNotifiedUsersCommit(..., wg)before starting go routing waiting onwg, asqueueNotifiedUsersCommit()doeswg.Add(1). This makes it impossible to hit this bug:Fixes: #34205