Skip to content

Conversation

sknrao
Copy link
Contributor

@sknrao sknrao commented Oct 3, 2024

This patch adds Powered-By-eBPF Logo to the Readme.rst.

This is based on the feedback received on PR #33982. Thanks to Quentin Monnet for the suggestions and logos. This patch is to support eBPF Logo trademark application by eBPF Foundation.

README.rst: Add "Powered-by-eBPF" and CNCF logos to README, link to ebpf.io and cncf.io

@sknrao sknrao requested review from a team as code owners October 3, 2024 08:47
@sknrao sknrao requested review from a user and bimmlerd October 3, 2024 08:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 3, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 3, 2024
@bimmlerd bimmlerd requested a review from xmulligan October 3, 2024 09:02
@bimmlerd
Copy link
Member

bimmlerd commented Oct 3, 2024

I think a cc @qmonnet is warranted, given he has looked into this in detail.

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

The change looks good to me, thanks a lot Sridhar for this PR 👍

image

image

@qmonnet qmonnet added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Oct 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 3, 2024
@qmonnet
Copy link
Member

qmonnet commented Oct 3, 2024

/test

@qmonnet qmonnet removed the request for review from a user October 3, 2024 09:41
@qmonnet
Copy link
Member

qmonnet commented Oct 3, 2024

BPF checks (checkpatch) complains because the author email is different than the one used in the sign-off-by tag, this is fine to ignore.

@bimmlerd
Copy link
Member

bimmlerd commented Oct 3, 2024

Unfortunately ci-ginkgo will not pass until you rebase onto latest main, due to #35193.

@sknrao
Copy link
Contributor Author

sknrao commented Oct 3, 2024

@bimmlerd should I do "update branch" (update with merge commit?)

@joestringer
Copy link
Member

@sknrao Better to do "Update with rebase" instead.

This patch adds Powered-By-eBPF Logo to the Readme.rst.

This is based on the feedback received on PR-33982.
Thanks to Quentin Monnet for the suggestions and logos.
This patch is to support eBPF Logo trademark application by eBPF
Foundation.

Signed-off-by: Sridhar K. N. Rao <srao@linuxfoundation.org>
@joestringer
Copy link
Member

/test

@joestringer joestringer added this pull request to the merge queue Oct 3, 2024
Merged via the queue into cilium:main with commit 8d712e6 Oct 3, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants