Skip to content

bgpv2: defining reconciler names and priorities constants #35181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

bgpv2: defining reconciler names and priorities constants #35181

merged 1 commit into from
Oct 3, 2024

Conversation

harsimran-pabla
Copy link
Contributor

Defining reconciler names and priorities at one place to avoid mistakes in order in which reconcilers are expected to run.

@harsimran-pabla
bgpv2: defining reconciler names and priorities constants
ce75ebd 
Defining reconciler names and priorities at one place to avoid mistakes
in order in which reconcilers are expected to run.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner October 2, 2024 18:13
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2024
@harsimran-pabla harsimran-pabla added the release-note/misc This PR makes changes that have no direct user impact. label Oct 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2024
@harsimran-pabla harsimran-pabla added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/bgp Impacts the Border Gateway Protocol feature. labels Oct 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2024
rastislavs
rastislavs approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have the priorities defined at one place, thx!

@rastislavs
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 3, 2024
@tklauser tklauser added this pull request to the merge queue Oct 3, 2024
Merged via the queue into cilium:main with commit acec4c0 Oct 3, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsimran-pabla @rastislavs @tklauser