Skip to content

servicemesh, ci: run internal to NodePort test #35177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

servicemesh, ci: run internal to NodePort test #35177

merged 1 commit into from
Oct 4, 2024

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Oct 2, 2024 •
edited
Loading

Currently, we were skipping internal to NodePort test for all matrix entries.

Fixes: #27304

@marseel
ci: run internal to NodePort test
fa74b70 
Currently, we were skipping internal to NodePort test for all matrix
entries.

Fixes: #27304

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2024
@marseel
Copy link
Contributor Author

marseel commented Oct 2, 2024

/ci-ingress

@marseel
Copy link
Contributor Author

marseel commented Oct 2, 2024

/test

@marseel marseel marked this pull request as ready for review October 2, 2024 13:28
@marseel marseel requested review from a team as code owners October 2, 2024 13:28
@marseel marseel requested review from sayboras and brlbil October 2, 2024 13:28
sayboras
sayboras approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮‍💨 Thanks

@marseel marseel added the release-note/ci This PR makes changes to the CI. label Oct 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 3, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 3490ed9 Oct 4, 2024
84 checks passed
@julianwiedmann julianwiedmann deleted the pr/marseel/fix_nodeport_ingress_test branch October 4, 2024 04:43
@sayboras sayboras added needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 4, 2024
@sayboras
Copy link
Member

sayboras commented Oct 4, 2024 •
edited
Loading

Let's backport this PR to all stable branches, so that we don't unintentionally break this functionality 🤞

@giorio94 giorio94 mentioned this pull request Oct 7, 2024
Merged
15 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 7, 2024
@giorio94 giorio94 mentioned this pull request Oct 7, 2024
Merged
9 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Oct 7, 2024
@giorio94
Copy link
Member

giorio94 commented Oct 7, 2024

Dropped needs-backport/1.14, as b7b375c is not part of the v1.14 tree.

@giorio94 giorio94 mentioned this pull request Oct 7, 2024
Merged
5 tasks
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 8, 2024
This was referenced Oct 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marseel @sayboras @giorio94 @brlbil @julianwiedmann