bgpv2: fix reconciliation of services with shared VIPs #35166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
710ce19 to
d1106cb
Compare
harsimran-pabla
requested changes
Oct 2, 2024
0506739 to
f7473bf
Compare
harsimran-pabla
approved these changes
Oct 3, 2024
YutaroHayakawa
approved these changes
Oct 4, 2024
f7473bf to
466feaf
Compare
|
/test |
466feaf to
5fa125f
Compare
|
/test |
rastislavs
commented
Oct 4, 2024
As multiple services can share the same VIP (e.g. using lbipam.cilium.io/sharing-key), the service reconciliation logic needs to be adapted to not withdraw a route to VIP that is still in use by some other service. To address that, this change introduces a new ReconcileResourceAFPaths method for reconciling BGP advertisements per resource and address family with integrated resource reference conting, that is used in the Service and PodIPPool reconcilers. This fix is specific to BGPv2 resource reconciliation only. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
5fa125f to
7f4ad69
Compare
harsimran-pabla
approved these changes
Oct 4, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As multiple services can share the same VIP (e.g. using
lbipam.cilium.io/sharing-key), the service reconciliation logic needs to be adapted to not withdraw a route to VIP that is still in use by some other service.To address that, this change introduces resource reference counting by reconciling service advertisements.
This fix is specific to BGPv2 service reconciliation only.
Part of #35018 (BGPv2 only)