bpf: nodeport: add L2 header before redirecting to overlay interface #35165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de269fd to
0ee7269
Compare
|
/test |
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
When redirecting from a L3 device to the overlay interface, we need to manually add a L2 header to the (inner) packet. cilium#33421 fixed this for the case of Nodeport NAT traffic from the LB node to a backend. Generalize it so that it helps all users of the nodeport_add_tunnel_encap() helper - for example DSR-Geneve or EgressGW reply traffic. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Validate that the from-netdev program adds a L2 header to the packet, before redirecting it to the overlay interface. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
0ee7269 to
361504f
Compare
|
/test |
|
(I've wanted to extend the test to also validate the tunnel_key / tunnel_opt, but hitting a weird issue in the test infra. So let's do this later) |
6 tasks
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redirecting from a L3 device to the overlay interface, we need to manually add a L2 header to the (inner) packet.
#33421 fixed this for the case of Nodeport NAT traffic from the LB node to a backend. Generalize it so that it helps all users of the nodeport_add_tunnel_encap() helper - for example DSR-Geneve or EgressGW reply traffic.