Skip to content

Conversation

julianwiedmann
Copy link
Member

The userspace fallback was deprecated in v1.16 with #31867. Let's remove it now.

Fixes: #33594

@julianwiedmann julianwiedmann added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. feature/wireguard Relates to Cilium's Wireguard feature labels Oct 1, 2024
@julianwiedmann julianwiedmann force-pushed the 1.17-wg-fallback branch 4 times, most recently from fb14355 to cc57258 Compare October 2, 2024 05:54
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann requested a review from gandro October 2, 2024 07:31
@julianwiedmann julianwiedmann marked this pull request as ready for review October 2, 2024 07:31
@julianwiedmann julianwiedmann requested review from a team as code owners October 2, 2024 07:31
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great diff! image

Thank you for taking care of this! 🙏

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianwiedmann Nice work!

@julianwiedmann
Copy link
Member Author

@learnitall ping 🙏

Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ping, LGTM 🚀

The userspace fallback was deprecated in v1.16 with
cilium#31867. Let's remove it now.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Remove a duplicated word.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 7, 2024
Merged via the queue into cilium:main with commit 7fa30c7 Oct 7, 2024
63 checks passed
@julianwiedmann julianwiedmann deleted the 1.17-wg-fallback branch October 7, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. feature/wireguard Relates to Cilium's Wireguard feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.17] wireguard: remove deprecated userspace fallback
5 participants