Skip to content

ginkgo: Get rid of K8sUpdates #35035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2024
Merged

ginkgo: Get rid of K8sUpdates #35035

merged 3 commits into from
Nov 29, 2024

Conversation

brb
Copy link
Member

@brb brb commented Sep 25, 2024

It got replaced by ci-e2e-upgrade.

@brb brb added kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. labels Sep 25, 2024
@brb
Copy link
Member Author

brb commented Sep 25, 2024

/test

@brb brb marked this pull request as ready for review September 25, 2024 17:21
@brb brb requested review from a team as code owners September 25, 2024 17:21
@brb brb force-pushed the pr/brb/rm-test-k8s-update branch 2 times, most recently from b9aef0b to a7cf775 Compare September 26, 2024 07:36
@brb
Copy link
Member Author

brb commented Sep 26, 2024

/test

@brb
Copy link
Member Author

brb commented Sep 27, 2024

https://github.com/cilium/cilium/blob/main/cilium-cli/connectivity/tests/errors.go#L56 is out of sync with https://github.com/cilium/cilium/blob/main/test/helpers/cons.go#L312. Since the cilium-cli got merged, we can just use one list. Converting this PR to draft until it has been resolved.

@brb brb marked this pull request as draft September 27, 2024 06:24
ldelossa
ldelossa approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from a7cf775 to 589d938 Compare October 4, 2024 11:50
@brb
Copy link
Member Author

brb commented Oct 4, 2024

/ci-e2e-upgrade

@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from 589d938 to 5255195 Compare October 4, 2024 13:05
@brb
Copy link
Member Author

brb commented Oct 4, 2024

/ci-e2e-upgrade

@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from 5255195 to 6201e01 Compare October 4, 2024 13:55
@brb
Copy link
Member Author

brb commented Oct 4, 2024

/ci-e2e-upgrade

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Nov 4, 2024
@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from 6201e01 to 32c5c87 Compare November 13, 2024 08:16
@brb
Copy link
Member Author

brb commented Nov 13, 2024

/test

@brb
Copy link
Member Author

brb commented Nov 25, 2024

/test

@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from 8619495 to 2e7a8ca Compare November 28, 2024 12:48
@brb
Copy link
Member Author

brb commented Nov 28, 2024

/ci-runtime

@brb
ginkgo: Get rid of K8sUpdates
2ccdfde 
It got replaced by ci-e2e-upgrade.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from 2e7a8ca to 2ccdfde Compare November 28, 2024 13:55
@brb
Copy link
Member Author

brb commented Nov 28, 2024

/test

gandro
gandro reviewed Nov 28, 2024
View reviewed changes
@brb
Copy link
Member Author

brb commented Nov 28, 2024

/ci-runtime

@brb
test/runtime: Start Cilium before running FQDN tests
3fd0da3 
Otherwise, the tests fail to start if they run after net_policies.go.

Suggested-by: Harsimran Pabla <hpabla@isovalent.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/rm-test-k8s-update branch from ce53e59 to 3fd0da3 Compare November 28, 2024 16:33
@brb
Copy link
Member Author

brb commented Nov 28, 2024

/ci-runtime

@brb
test/runtime: Start Cilium before monitor tests
2831c57 
Same reasoning as in the previous commit.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
Copy link
Member Author

brb commented Nov 28, 2024

/ci-runtime

@brb
Copy link
Member Author

brb commented Nov 29, 2024

/test

@brb brb mentioned this pull request Nov 29, 2024
Closed
@brb brb marked this pull request as ready for review November 29, 2024 09:04
@brb brb requested review from a team as code owners November 29, 2024 09:04
@brb brb requested review from nathanjsweet and kaworu November 29, 2024 09:04
@aanm aanm enabled auto-merge November 29, 2024 09:20
@aanm aanm added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 7b51d7a Nov 29, 2024
274 checks passed
@aanm aanm deleted the pr/brb/rm-test-k8s-update branch November 29, 2024 09:58
julianwiedmann added a commit that referenced this pull request Feb 28, 2025
@julianwiedmann
test: remove K8sUpdates leftovers
9c837bc 
Remove unused code that was left behind by
#35035.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann mentioned this pull request Feb 28, 2025
Merged
julianwiedmann added a commit that referenced this pull request Feb 28, 2025
@julianwiedmann
test: remove K8sUpdates leftovers
dd6bfc1 
Remove unused code that was left behind by
#35035.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2025
@julianwiedmann
test: remove K8sUpdates leftovers
2dce02a 
Remove unused code that was left behind by
#35035.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro left review comments

@brlbil brlbil brlbil approved these changes

@ldelossa ldelossa ldelossa approved these changes

@aanm aanm aanm approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/fqdn

@kaworu kaworu Awaiting requested review from kaworu kaworu is a code owner automatically assigned from cilium/sig-hubble

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brb @gandro @brlbil @ldelossa @aanm @bimmlerd