feat(clustermesh): Deploy in parallel the connections #35021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2b3973 to
f108fdf
Compare
f108fdf to
e639dde
Compare
example: > cilium clustermesh connect --destination-context kindB,kindC,kindD,kindE --parallel 4 Signed-off-by: Joseph Ligier <joseph.ligier@gmail.com>
|
/test |
|
@thorn3r in github action integration tests, i saw a problem "github.com/cilium/cilium/operator/pkg/ciliumidentity". i don't think it's related to my feature. |
|
@littlejo Yeah it looks like it hit this flake. I kicked off a rerun, but doesn't appear to be related to your change 👍 |
|
@thorn3r i tested with
|
pchaigno
approved these changes
Oct 5, 2024
asauber
approved these changes
Oct 7, 2024
|
LGTM, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: If you manage multiple Kubernetes clusters, it can be beneficial to parallelize the connection processes. However, running
helm upgradein parallel consumes significant CPU resources. Therefore, it's important to customize the resource limits accordingly.Example of cli for 2 connections in parallel:
cilium clustermesh connect --destination-context kindB,kindC,kindD,kindE --parallel 2By default
--parallel=1How it works:
An improvement could be to parallelize both the current context and the remote contexts. However, it seems like a lot of work for minimal gain.
Example of log with timestamp (7 clusters kind and
--parallel=5):In total it took 36 seconds (estimated with no parallel: 7x7 = ~49 seconds)
Example of log with timestamp (7 clusters kind and
--parallel=3):In total it took 33 seconds (better option than 5 parallels because the server only has 4 vCPU)
Test on 64 EKS clusters with
--parallel=7and Pulumi (on 8vCPU): 132s (about 7 + 9*14): YoutubePlease ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number