cilium-cli: Show config.cilium.io annotations on configmap #35020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
commented
Sep 24, 2024
tklauser
reviewed
Sep 24, 2024
70c7a94 to
600ab63
Compare
600ab63 to
a682e38
Compare
joestringer
reviewed
Sep 24, 2024
a682e38 to
050a398
Compare
|
/test |
gandro
reviewed
Sep 26, 2024
Add support to "cilium status" for showing config.cilium.io/ annotations in configmaps/cilium-config.
This allows marking non-fatal issues in the configuration and showing them to the user.
Example output with configmaps/cilium-config with annotation
{"config.cilium.io/example": "This is an example error"}:
$ cilium status
...
Configuration: This is an example error
Signed-off-by: Jussi Maki <jussi@isovalent.com>
050a398 to
05587a4
Compare
gandro
approved these changes
Sep 26, 2024
|
/test |
asauber
reviewed
Sep 27, 2024
asauber
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for showing config.cilium.io annotations in configmaps/cilium-config in "cilium status". This allows informing the user of a non-fatal misconfigured or unsupported configuration.
Example output with annotation {"config.cilium.io/example": "This is an example warning"}: