Remove deprecated annotations-based L7 visibility #35019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
cb24ec4 to
c6611cf
Compare
|
/ci-ginkgo |
c6611cf to
3fb4b85
Compare
|
/ci-ginkgo |
3fb4b85 to
cc7205a
Compare
|
/ci-ginkgo |
|
/ci-integration |
|
/test |
|
/ci-integration Hit #34092: https://github.com/cilium/cilium/actions/runs/11012829080/job/30579864094 |
cc7205a to
4f31e62
Compare
|
/test |
YutaroHayakawa
approved these changes
Sep 25, 2024
brlbil
approved these changes
Sep 25, 2024
squeed
reviewed
Sep 27, 2024
squeed
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Looks good. Would like to have @jrajahalme's review before merging.
There's a minor docs change needed, otherwise this is good.
L7 visibility using Pod annotations is deprecated and the feature will be removed in a successive commit. Switch K8sAgentHubbleTest still using it to use L7 visibility policy instead. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Previously it was possible to enable L7 protocol visibility using the policy.cilium.io/proxy-visibility annotation. That method has various known bugs, is no longer supported and has been deprecated since Cilium 1.15, see #28449. Signed-off-by: Tobias Klauser <tobias@cilium.io>
…alue The error return value is always nil, remove it. Signed-off-by: Tobias Klauser <tobias@cilium.io>
4f31e62 to
5d88f2c
Compare
|
/test |
|
@jrajahalme @learnitall could you please take a look? |
jrajahalme
approved these changes
Oct 1, 2024
aanm
approved these changes
Oct 1, 2024
Sure, will open separate backports for these. |
qmonnet
approved these changes
Oct 1, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to enable L7 protocol visibility using the
policy.cilium.io/proxy-visibilityPod annotation. That method has various bugs, is no longer supported and has been deprecated since Cilium 1.15, see #28449.See commits for details.