Skip to content

envoy: Configure internal_address_config to avoid warning log #35090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

envoy: Configure internal_address_config to avoid warning log #35090

merged 1 commit into from
Oct 22, 2024

Conversation

sayboras
Copy link
Member

Relates: #34968

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Sep 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2024
@sayboras
Copy link
Member Author

/test

@sayboras
Copy link
Member Author

/test-ci-gateway

@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras marked this pull request as ready for review September 30, 2024 11:53
@sayboras sayboras requested review from a team as code owners September 30, 2024 11:53
mhofstetter
mhofstetter reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - i left some questions inline.

@sayboras sayboras force-pushed the pr/tammach/internal-address-config-main branch from 557f650 to ea87a76 Compare October 21, 2024 13:47
@sayboras sayboras requested a review from mhofstetter October 21, 2024 13:48
@sayboras
Copy link
Member Author

/test

@sayboras
envoy: Configure internal_address_config to avoid warning log
d0c078d 
Relates: #34968
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/internal-address-config-main branch from ea87a76 to d0c078d Compare October 22, 2024 06:56
@mhofstetter
Copy link
Member

/test

mhofstetter
mhofstetter approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mhofstetter mhofstetter added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/servicemesh GH issues or PRs regarding servicemesh labels Oct 22, 2024
@sayboras sayboras enabled auto-merge October 22, 2024 08:24
@sayboras sayboras added needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch backport/author The backport will be carried out by the author of the PR. labels Oct 22, 2024
@sayboras sayboras added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit ff537f3 Oct 22, 2024
262 checks passed
@sayboras sayboras deleted the pr/tammach/internal-address-config-main branch October 22, 2024 09:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 22, 2024
@sayboras sayboras mentioned this pull request Oct 22, 2024
Merged
1 task
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Oct 22, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 22, 2024
sayboras added a commit that referenced this pull request Nov 12, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
3e649ba 
This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Nov 12, 2024
Merged
This was referenced Nov 13, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
c4b1379 
This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 18, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
05087bb 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 18, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
caad130 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 18, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
2f156af 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 19, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
ec4fb04 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 19, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
bc0f398 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 27, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
4b1ab99 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 27, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
f6723fe 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 27, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
a72e02b 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 28, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
6db2ecd 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 28, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
c9abb40 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 28, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
294bc44 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Nov 28, 2024
Closed
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@sayboras
envoy: Configure internal_address_config to avoid warning log
e01c024 
[ upstream commit c4b1379 ]

This was missed in the previous PR #35090

Relates: #34968, #35090
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@jijiechen jijiechen mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/servicemesh GH issues or PRs regarding servicemesh backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayboras @mhofstetter