datapath, netkit: Allow ARP passthrough on host when using netkit #35070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
When using the `netkit` datapath mode neither `ENABLE_ARP_PASSTHROUGH` nor `ENABLE_ARP_RESPONDER` is set for any endpoint. When host firewall is enabled all ARP messages are blocked to and from the netdev. Make an exception for host endpoints to ensure connectivity is maintained between the host and the outside world. Additionally, add test coverage for netkit combined with host firewall. Fixes: cilium#34230 Fixes: 6895341 ("cilium, connector: Add netkit connector") Signed-off-by: Jordan Rife <jrife@google.com>
|
cc @borkmann |
pchaigno
approved these changes
Oct 2, 2024
|
Thanks for the fix! /test |
borkmann
approved these changes
Oct 2, 2024
rgo3
approved these changes
Oct 2, 2024
|
(ready to merge. the ginkgo ci failure appears also in other PRs and unrelated to this one here, looks like we don't have a GH issue for it yet) edit: #35209 |
|
thanks @borkmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
netkitdatapath mode neitherENABLE_ARP_PASSTHROUGHnorENABLE_ARP_RESPONDERis set for any endpoint. When host firewall is enabled all ARP messages are blocked to and from the netdev. Make an exception for host endpoints to ensure connectivity is maintained between the host and the outside world. Additionally, add test coverage for netkit combined with host firewall.Fixes: #34230
Fixes: 6895341 ("cilium, connector: Add netkit connector")