Skip to content

docs: Fix markdown in pkg/loadbalancer/experimental/README.md #35065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

docs: Fix markdown in pkg/loadbalancer/experimental/README.md #35065

merged 1 commit into from
Oct 1, 2024

Conversation

DamianSawicki
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This is mostly to fix how the "basic architecture" diagram and command-line snippets are displayed. Some more backticks added here and there.

@DamianSawicki
docs: Fix markdown in experimental README
c8f530e 
Signed-off-by: Damian Sawicki <dsawicki@google.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 27, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 27, 2024
@DamianSawicki
Copy link
Contributor Author

@joamaki Readme has not displayed correctly, I've fixed it. Please let me know whether it is fine to submit it independently or would be better to combine it with some more significant changes.

joamaki
joamaki reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Sep 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2024
@joamaki joamaki marked this pull request as ready for review September 30, 2024 08:02
@joamaki joamaki requested a review from a team as a code owner September 30, 2024 08:02
@joamaki
Copy link
Contributor

joamaki commented Sep 30, 2024

/test

@joamaki joamaki enabled auto-merge September 30, 2024 08:02
@joamaki joamaki removed the request for review from julianwiedmann September 30, 2024 08:03
@joamaki joamaki added this pull request to the merge queue Oct 1, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 1, 2024
Merged via the queue into cilium:main with commit 2c3b320 Oct 1, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamianSawicki @joamaki