-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: hubble exporter filter test with clashing filters #35058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the other events in the list to also use the source endpoint field?
076284f
to
470479c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, actually I think the test cases are now a bit confusing as to what is expected to be returned since now only one of the allow-pods
is being returned. Perhaps we should change the namespace: "allow-pod"
so that it's not so confusing? It could be more arbitrary just like "namespace-a" and "namespace-b" and then update the filters to pick one of them and edit the results as expected.
470479c
to
da3592c
Compare
…ist. Signed-off-by: Igor Klemenski <igor.klemenski@microsoft.com>
da3592c
to
1aaa714
Compare
For sure, the namespaces we now filter on are called |
@rolinh Mind taking a quick look? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/test |
Fixes bug in test where a flow matching both the white- and blacklist was not getting filtered out.
Fix suggested by @chancez and @glibsm