Skip to content

test: add dual-stack to delegated IPAM E2E test #34937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

test: add dual-stack to delegated IPAM E2E test #34937

merged 1 commit into from
Sep 27, 2024

Conversation

wedaly
Copy link

@wedaly wedaly commented Sep 17, 2024

Extend delegated IPAM E2E test to cover dual-stack.

Fixes: #34788

test: add dual-stack to delegated IPAM E2E test
506af63 
Signed-off-by: Will Daly <widaly@microsoft.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 17, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 17, 2024
@wedaly wedaly marked this pull request as ready for review September 17, 2024 22:59
@wedaly wedaly requested review from a team as code owners September 17, 2024 22:59
@wedaly wedaly requested a review from brlbil September 17, 2024 22:59
@wedaly
Copy link
Author

wedaly commented Sep 17, 2024

Tested this on my fork, here is the GH Action run: https://github.com/wedaly/cilium/actions/runs/10912287446/job/30286652385

@brlbil
Copy link
Contributor

brlbil commented Sep 25, 2024

/test

brlbil
brlbil approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @wedaly

@joestringer joestringer added the release-note/ci This PR makes changes to the CI. label Sep 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 27, 2024
@joestringer joestringer added this pull request to the merge queue Sep 27, 2024
Merged via the queue into cilium:main with commit e569ea1 Sep 27, 2024
71 checks passed
@wedaly wedaly deleted the delegated-ipam-e2e-dual-stack branch September 27, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: E2E tests for delegated IPAM
3 participants
@wedaly @brlbil @joestringer