-
Notifications
You must be signed in to change notification settings - Fork 3.4k
daemon: bpf: add --bpf-conntrack-accounting-enabled flag #34921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8bca9e6
to
7d58f26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm LGTM. But is there a reason there is no usage or help flag like so?:
cilium/daemon/cmd/daemon_main.go
Lines 384 to 385 in 59f0244
flags.Bool(option.BPFEventsTraceEnabled, defaults.BPFEventsTraceEnabled, "Expose 'trace' events for Cilium monitor and/or Hubble") | |
option.BindEnv(vp, option.BPFEventsTraceEnabled) |
In particular I'm not sure the configmap bit is picked up without BindEnv. Am I missing something?
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
7d58f26
to
61cc03e
Compare
nite catch, I just overlooked that
(didn't notice I was missing it as the agent is still picking up the flag from the configmap) |
/test |
Ah right, because the configmap is mounted and read manually, and not via ENV variables |
No description provided.