Skip to content

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Sep 20, 2024

Explicit how a Hubble API user can request flows with "any interface" set, by setting a non-empty repeated interface filter (e.g. non-empty slice from Go) with a zero values filter. Like other filters, a logical inverse of this "any interface" filter can be queried using the same construction under the GetFlowsRequest.blacklist set of filters instead of GetFlowsRequest.whitelist.

@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. sig/hubble labels Sep 20, 2024
@kaworu kaworu requested a review from glibsm September 20, 2024 11:54
@kaworu kaworu self-assigned this Sep 20, 2024
@kaworu kaworu requested a review from a team as a code owner September 20, 2024 11:54
@kaworu
Copy link
Member Author

kaworu commented Sep 25, 2024

/test

Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 26, 2024
Explicit how a Hubble API user can request flows with "any interface"
set, by setting a non-empty repeated interface filter (e.g. non-empty
slice from Go) with a zero values filter. Like other filters, a logical
inverse of this "any interface" filter can be queried using the same
construction under the GetFlowsRequest.blacklist set of filters instead
of GetFlowsRequest.whitelist.

Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu force-pushed the pr/kaworu/hubble/any-interface-filter-test-cases branch from f964e5e to b71bba6 Compare October 30, 2024 16:32
@kaworu kaworu removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 30, 2024
@kaworu
Copy link
Member Author

kaworu commented Nov 4, 2024

/test

@kaworu kaworu added this pull request to the merge queue Nov 13, 2024
Merged via the queue into cilium:main with commit a184399 Nov 13, 2024
64 checks passed
@kaworu kaworu deleted the pr/kaworu/hubble/any-interface-filter-test-cases branch November 13, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants