Add concurrency to e2e-upgrade tests #34806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-e2e-upgrade |
f6230b2 to
6e55881
Compare
|
/ci-e2e-upgrade |
6e55881 to
67c152f
Compare
|
/ci-e2e-upgrade |
67c152f to
04eabbb
Compare
|
/ci-e2e-upgrade |
04eabbb to
1704847
Compare
|
/ci-e2e-upgrade |
1704847 to
4e9e6f9
Compare
|
/ci-e2e-upgrade |
1 similar comment
|
/ci-e2e-upgrade |
4e9e6f9 to
ce7e3c9
Compare
|
/ci-e2e-upgrade |
ce7e3c9 to
e397240
Compare
|
/ci-e2e-upgrade |
e397240 to
815a084
Compare
|
/ci-e2e-upgrade |
815a084 to
a1a1019
Compare
|
/ci-e2e-upgrade |
a1a1019 to
e95a1be
Compare
|
/ci-e2e-upgrade |
6939529 to
3e00088
Compare
|
/ci-e2e-upgrade |
3e00088 to
8b9cc75
Compare
|
/ci-e2e-upgrade |
8b9cc75 to
269dac3
Compare
|
/ci-e2e-upgrade |
Adding concurrency to tests-e2e upgrade workflow helps to decrease the time it takes to run the tests on our CI. | Name | Before | After | Time Decreased | |-----------|-----------|-----------|----------------| | Test 1 | 00:49:18 | 00:25:14 | -48.82% | | Test 2 | 00:46:53 | 00:24:37 | -47.49% | | Test 3 | 00:47:12 | 00:25:14 | -46.54% | | Test 4 | 00:55:41 | 00:32:41 | -41.30% | | Test 5 | 00:52:23 | 00:28:58 | -44.70% | | Test 6 | 01:07:00 | 00:38:44 | -42.19% | | Test 7 | 01:10:00 | 00:39:11 | -44.02% | | Test 8 | 00:56:24 | 00:32:19 | -42.70% | | Test 9 | 00:54:19 | 00:32:27 | -40.26% | | Test 10 | 00:48:46 | 00:25:52 | -46.96% | | Test 11 | 01:04:00 | 00:31:34 | -50.68% | | Test 12 | 01:03:00 | 00:37:17 | -40.82% | | Test 13 | 00:46:53 | 00:22:37 | -51.76% | | Test 14 | 01:01:00 | 00:37:01 | -39.32% | | Test 15 | 00:58:01 | 00:32:17 | -44.36% | | Test 16 | 01:02:00 | 00:35:16 | -43.12% | | Test 17 | 01:01:00 | 00:33:11 | -45.60% | | Test 18 | 00:59:33 | 00:31:09 | -47.69% | | Test 19 | 01:02:00 | 00:34:44 | -43.98% | | Test 20 | 01:04:00 | 00:35:07 | -45.13% | | Test 21 | 01:01:00 | 00:39:52 | -34.64% | | Test 22 | 01:05:00 | 00:35:15 | -45.77% | | Test 23 | 00:30:29 | 00:16:50 | -44.78% | Signed-off-by: André Martins <andre@cilium.io>
Since a lot of flakes were being caused by these tests we need to run them separately first and then run all the other tests concurrently. We will rename the tests that need to be run sequentially by prefixing their names with "seq-". Signed-off-by: André Martins <andre@cilium.io>
Splitting the connectivity tests commands together with comments will make it clear what are we testing as this was causing some confusion which tests were being tested on each "cilium connectivity" invocation. Signed-off-by: André Martins <andre@cilium.io>
With the introduction of concurrent tests, it takes a little bit more time for all the services to be propagated. Thus we need to increase the timeout from 30 seconds to 1 minute. Signed-off-by: André Martins <andre@cilium.io>
269dac3 to
a847efb
Compare
|
/ci-e2e-upgrade |
With the introduction of concurrent tests, it takes a little bit more time for all the policies to be propagated. Thus we need to increase the timeout from 15 seconds to 30 seconds. Signed-off-by: André Martins <andre@cilium.io>
|
/test |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes on this PR helps to decrease the test run time significantly. During testing if this was possible, a lot of flakes were being caused by the egress-gateway, egress-gateway-with-l7-policy and from-cidr-host-netns tests which is why they run separately without concurrency and then all the other tests run parallel afterwards.
You can find 6 successful runs in https://github.com/cilium/cilium/actions/runs/11220270835. The attempt #4 that failed was caused by a faulty connection to one.one.one.one.