nodeinit: remove workaround for Azure CNI bridge mode #34870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure CNI has defaulted to transparent mode since 2020 (see Azure/azure-container-networking#709) and today all AKS clusters on a supported version (1.27 or later) are running in transparent mode. Cilium no longer needs workarounds to force Azure CNI from bridge mode to transparent mode, so remove these steps from the nodeinit script. Signed-off-by: Will Daly <widaly@microsoft.com>
|
/test |
|
Hi @wedaly , iust a bit curious, why Azure convert from bridge mode to transparent mode? Isn't the performance of bridge mode better than Linux routing? |
|
/ci-aks |
joamaki
approved these changes
Sep 20, 2024
@ruicao93 this part of the AKS docs is a pretty good description of the problems with bridge mode: https://github.com/MicrosoftDocs/azure-docs/blob/32ecba35211b602b74596d6753b3fcd4a3a90f41/articles/aks/faq.md#benefits-of-transparent-mode (it's since been deleted from the public docs, but you can see it in the git history). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure CNI has defaulted to transparent mode since 2020 (see Azure/azure-container-networking#709) and today all AKS clusters on a supported version (1.27 or later) are running in transparent mode.
Cilium no longer needs workarounds to force Azure CNI from bridge mode to transparent mode, so remove these steps from the nodeinit script.