Improve speed on lint commits GH workflow #34848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d81de00 to
b3236fe
Compare
ccache can be used to speed up builds of bpf programs. Signed-off-by: André Martins <andre@cilium.io>
With theses changes, the workflow run time will decreases tremendously up with the usage of ccache and golang caches. Signed-off-by: André Martins <andre@cilium.io>
joestringer
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Nice work 💯
I agree in theory this could be missing some things leading to breakage, but generally speaking the bpf code is pretty self-contained and almost all C dependencies are under that path. I can't think of any particular dependencies for the C datapath build that reside outside this directory other than maybe a few makefiles.
Given the benefits of this, I think it's well worth merging this as-is. If it turns out that we frequently hit issues due to the way this PR detects changes in the tree, then those should become quite apparent by breaking the tree, and then we can revisit whether to iterate further on these heuristics.
christarazi
approved these changes
Sep 13, 2024
This was referenced Oct 8, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cache to improve the build times of lint commit. As an example, a PR with 3-4 commits was taking: