Use Go standard library slices package more extensively #34796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
approved these changes
Sep 10, 2024
dylandreimerink
approved these changes
Sep 10, 2024
sayboras
approved these changes
Sep 10, 2024
a9eaab3 to
807bfc4
Compare
|
/test Rebased to resolve merge conflict. |
harsimran-pabla
approved these changes
Sep 10, 2024
qmonnet
approved these changes
Sep 10, 2024
The former is available since Go 1.21 and the latter is merely a wrapper around it when using Go ≥ 1.21. Use the standard library package directly. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Doing this because the slices functions are slightly faster and easier to use. It also removes one dependency layer. This requires changing SortedUniqueFunc to take the less function as a func(a, b T) instead of func(i, j int) which is more idiomatic anyway. Signed-off-by: Tobias Klauser <tobias@cilium.io>
This allows GC to reclaim memory for these elements. Signed-off-by: Tobias Klauser <tobias@cilium.io>
807bfc4 to
9a0cfa4
Compare
|
/test Rebased to resolve conflicts, once again. |
In recent Go versions sort.{Ints,Strings} is already implemented in
terms of slices.Sort. This change removes that indirection and a
dependency layer.
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Use the generic Contains* functions from the slices Go standard library package instead of open-coding them across the code base. This also allows simplifying some code. Signed-off-by: Tobias Klauser <tobias@cilium.io>
9a0cfa4 to
13413c4
Compare
|
/test |
rolinh
approved these changes
Sep 11, 2024
julianwiedmann
approved these changes
Sep 11, 2024
nathanjsweet
approved these changes
Sep 11, 2024
|
❤️ the simplification! Thanks @tklauser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of some newly added functionality added in Go 1.23.
See commit messages for details.