Skip to content

k8s: support for loadbalancer svc ip mode #34780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

k8s: support for loadbalancer svc ip mode #34780

merged 1 commit into from
Oct 8, 2024

Conversation

dakehero
Copy link
Contributor

@dakehero dakehero commented Sep 9, 2024 •
edited
Loading

This patch implements KEP-1860 for cilium kube-proxy replacement. This feature has been an alpha feature since K8s 1.29 and recently became a beta feature in 1.30.

In a word, kube-proxy should only perform loadbalancing for LoadbalancerIP when the IPMode is "VIP" or empty.

@dakehero dakehero requested a review from a team as a code owner September 9, 2024 13:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 9, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 9, 2024
@maintainer-s-little-helper
Copy link

Commit 19ea13b does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 9, 2024
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 19ea13b to 9a50eae Compare September 9, 2024 14:00
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 9, 2024
@maintainer-s-little-helper
Copy link

Commit 1da5aab does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 9, 2024
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 1da5aab to a9cc48e Compare September 10, 2024 02:47
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 10, 2024
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from a9cc48e to 5946572 Compare September 11, 2024 07:41
@dylandreimerink dylandreimerink added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 12, 2024
@ldelossa
Copy link
Contributor

@dakehero - PR needs a rebase.

@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch 2 times, most recently from 2d276cf to 768c0ee Compare September 18, 2024 02:38
@dakehero
Copy link
Contributor Author

@ldelossa Done. Thanks.

@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 768c0ee to 5eb24da Compare September 18, 2024 06:44
@dakehero
Copy link
Contributor Author

@nathanjsweet Hi, could you help to review this PR?

@nathanjsweet
Copy link
Member

LGTM.

@maintainer-s-little-helper
Copy link

Commit 3a447d4 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 24, 2024
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 3a447d4 to 6f3071a Compare September 24, 2024 02:49
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 24, 2024
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 6f3071a to 74a38cb Compare September 24, 2024 06:47
@dakehero
Copy link
Contributor Author

Thanks @nathanjsweet, I think this PR is ready to merge.

@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 74a38cb to 623e3f4 Compare September 26, 2024 03:22
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch 2 times, most recently from cc05962 to 84466b7 Compare September 29, 2024 06:05
@julianwiedmann
Copy link
Member

/test

@julianwiedmann
Copy link
Member

Looks like this needs a rebase: https://github.com/cilium/cilium/actions/runs/11127833045/job/30927762192#step:17:533

@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from 84466b7 to c30f3ac Compare October 2, 2024 06:05
@dakehero
Copy link
Contributor Author

dakehero commented Oct 2, 2024

thanks@julianwiedmann

@julianwiedmann
Copy link
Member

/test

@julianwiedmann
Copy link
Member

The new test still looks unhappy. Maybe you need to explicitly state the ForwardingMode? Please have a look and repro locally if possible.

@dakehero
k8s: support for loadbalancer svc ip mode
9295482 
This patch implements KEP-1860 for cilium kube-proxy replacement.
This feature has been an alpha feature since K8s 1.29 and recently
became beta feture in 1.30.

In a word, kube-proxy should only perform loadbalancing for
LoadbalancerIP when the IPMode is "VIP" or empty.

Signed-off-by: Quan Wei <quanwei.153@bytedance.com>
@dakehero dakehero force-pushed the feat/service/loadbalancer-ipmode branch from c30f3ac to 9295482 Compare October 8, 2024 03:17
@dakehero
Copy link
Contributor Author

dakehero commented Oct 8, 2024

@julianwiedmann thanks, I just fixed it, could you please trigger tests again?

@julianwiedmann
Copy link
Member

/ci-runtime

@julianwiedmann
Copy link
Member

/test

@julianwiedmann julianwiedmann added the area/loadbalancing Impacts load-balancing and Kubernetes service implementations label Oct 8, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 8, 2024
Merged via the queue into cilium:main with commit ab8557c Oct 8, 2024
63 checks passed
@baurmatt baurmatt mentioned this pull request Oct 25, 2024
Closed
@aojea
Copy link
Contributor

aojea commented Oct 25, 2024

Love it, thanks for doing this and be a reference of implementing Kubernetes APIs

@aojea aojea mentioned this pull request Jan 27, 2025
Closed
@mtneug mtneug mentioned this pull request Aug 3, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dakehero @ldelossa @nathanjsweet @julianwiedmann @aojea @dylandreimerink