Skip to content

bpf: vxlan helper improvements #34755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2024
Merged

bpf: vxlan helper improvements #34755

merged 3 commits into from
Sep 16, 2024

Conversation

julianwiedmann
Copy link
Member

A bit of cleanups, hopefully enough to support native L3 devices.

@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Sep 9, 2024
@julianwiedmann julianwiedmann requested review from a team as code owners September 9, 2024 05:53
@julianwiedmann
Copy link
Member Author

/test

@pchaigno pchaigno requested review from smagnani96 and removed request for pchaigno September 9, 2024 08:39
@julianwiedmann
Copy link
Member Author

/test

smagnani96
smagnani96 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@smagnani96 smagnani96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I just left small nit comments.

ldelossa
ldelossa reviewed Sep 9, 2024
View reviewed changes
ldelossa
ldelossa approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A bit a confusion I have, most likely with my own knowledge, about the removal of the validation after eth rewrite. Left a Q.

Edit: resolved Q by staring at the code long enough 🤖

@julianwiedmann
bpf: vxlan: clean up stale comments
957a61f 
The referenced helper doesn't exist any longer.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: vxlan: let caller provide the L4 offset
b960cb1 
The VXLAN helpers currently assume that the outer packet has a L2 header,
but this isn't necessarily true. Instead of hard-coding the `struct ethhdr`
length, let the caller use ETH_HLEN instead (which can be either 14 or 0).

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: encrypt: avoid extra validation in encrypted-overlay path
0abebcf 
Determine the L4 offset just once, so that we don't have to revalidate
the IPv4 header after rewriting the MAC addresses.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Sep 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 16, 2024
Merged via the queue into cilium:main with commit 4f51bad Sep 16, 2024
62 checks passed
@julianwiedmann julianwiedmann deleted the 1.17-bpf-vxlan-helpers branch September 16, 2024 17:43
@julianwiedmann julianwiedmann added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 23, 2024
@tklauser tklauser mentioned this pull request Oct 25, 2024
Merged
7 tasks
@tklauser tklauser added the backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. label Oct 25, 2024
@tklauser tklauser removed the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 25, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 25, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@pchaigno pchaigno pchaigno approved these changes

@smagnani96 smagnani96 smagnani96 approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julianwiedmann @pchaigno @ldelossa @smagnani96 @tklauser