Skip to content

chore: fix some function names #34626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: fix some function names #34626

merged 1 commit into from
Nov 5, 2024

Conversation

jinjiadu
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

fix some function names

<!-- Enter the release note text here if needed or remove this section! -->

@jinjiadu jinjiadu requested review from a team as code owners August 31, 2024 05:58
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 31, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 31, 2024
@learnitall learnitall added the release-note/misc This PR makes changes that have no direct user impact. label Sep 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 5, 2024
learnitall
learnitall approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

doniacld
doniacld approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@doniacld doniacld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@learnitall
Copy link
Contributor

/test

@aanm
Copy link
Member

aanm commented Oct 11, 2024

@jinjiadu thank you. Unfortunately the CI is failing here. Can you take a look?

@dylandreimerink
Copy link
Member

@jinjiadu It seems you need to rerun some of our generation tooling to fix the CI issue: make generate-api generate-health-api generate-hubble-api generate-operator-api generate-kvstoremesh-api

@jinjiadu
Copy link
Contributor Author

@jinjiadu It seems you need to rerun some of our generation tooling to fix the CI issue: make generate-api generate-health-api generate-hubble-api generate-operator-api generate-kvstoremesh-api

Thanks! The cmd has been Executed.

@learnitall
Copy link
Contributor

Hey @jinjiadu, would you mind rebasing? Looks like the "Build Commits workflow is failing due to #34848

@jinjiadu
chore: fix some function names
fe4e710 
Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
@jinjiadu
Copy link
Contributor Author

Hey @jinjiadu, would you mind rebasing? Looks like the "Build Commits workflow is failing due to #34848

Thanks! Rebased.

@aanm aanm enabled auto-merge November 4, 2024 10:25
@aanm
Copy link
Member

aanm commented Nov 4, 2024

/test

@julianwiedmann julianwiedmann added kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Nov 5, 2024
@aanm aanm added this pull request to the merge queue Nov 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 5, 2024
Merged via the queue into cilium:main with commit a47d461 Nov 5, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick approved these changes

+2 more reviewers

@learnitall learnitall learnitall approved these changes

@doniacld doniacld doniacld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jinjiadu @learnitall @aanm @dylandreimerink @youngnick @doniacld @julianwiedmann