iptables: periodically run rules reconciliation to fix possible drifts #34661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparation for the subsequent change (and the associated test), let's modify the iptables reconciler to take a clock instance as parameter, and leverage the available fake implementation in the unit test. This enables granular time control for improved testing, as well as reduced test duration. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
07b336f ("iptables: Add rules runtime reconciliation") introduced a reconciler to manage the configuration of iptables rules and react to updates of external facing network devices and local node parameters. As an additional measure to ensure eventual consistency of the iptables rules, let's also periodically rerun the full reconciliation process. This aims to fix possible inconsistencies caused by external modifications, such as due to startup race conditions between Cilium and kube-proxy. The reconciliation interval is currently configured to 30 minutes to limit the amount of additional churn, and the reconciliation gets automatically rescheduled if it had already been triggered in the same period. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
ysksuzuki
approved these changes
Sep 4, 2024
3 tasks
HadrienPatte
added a commit
that referenced
this pull request
Aug 8, 2025
This is a followup to #34661. Now that cilium uses go 1.24, it is safe to remove the pre-go1.23 workaround for timer reset. See https://go.dev/wiki/Go123Timer Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
07b336f ("iptables: Add rules runtime reconciliation") introduced a reconciler to manage the configuration of iptables rules and react to updates of external facing network devices and local node parameters.
As an additional measure to ensure eventual consistency of the iptables rules, let's also periodically rerun the full reconciliation process. This aims to fix possible inconsistencies caused by external modifications, such as due to startup race conditions between Cilium and kube-proxy. The reconciliation interval is currently configured to 30 minutes to limit the amount of additional churn, and the reconciliation gets automatically rescheduled if it had already been triggered in the same period.