connectivity: Introdue Multicast connectivity test #34530
Conversation
|
@christarazi @tommyp1ckles @ldelossa Due to my operational error, the contents of the previous PR commit were erased. Some questions mentioned in previous PR were resolved at the last APAC Dev Meeting. cc. @fujitatomoya |
55f6ab0 to
e2cc9d1
Compare
|
@christarazi @tommyp1ckles @ldelossa I'm sorry for repeatedly mentioning. |
e2cc9d1 to
624fd7f
Compare
|
/test |
|
@dylandreimerink I've done git rebase |
0e7eaf3 to
1138208
Compare
|
@christarazi @asauber @dylandreimerink @tommyp1ckles @ldelossa I'm sorry for mentioning. |
|
I can't review it since I am not part of the codeowners for this PR, I am merely doing the admin like setting labels and triggering tests for which you need some privileges. I hope @christarazi and @asauber can find some time to review it, otherwise we can request alternative reviewers from the respective teams. |
There was a problem hiding this comment.
The implementation here looks fine to me. It's mostly in line with our other connectivity tests, in particular the BGP tests.
Would you be able to do some interactive testing and confirm that we can use the alpine/socat container image rather than the nicolaka/netshoot container for these tests?
$ docker save docker.io/nicolaka/netshoot:v0.13@sha256:a20c2531bf35436ed3766cd6cfe89d352b050ccc4d7005ce6400adf97503da1b -o netshoot.tar
$ docker save docker.io/alpine/socat:1.7.4.4@sha256:93efcf633c5489b170404df25e289f811cabeea728a5367f0c9b1560982edf14 -o alpinesocat.tar
$ ls -la
total 551860
drwxrwxr-x 2 ubuntu ubuntu 4096 Oct 7 16:50 .
drwxr-x--x 17 ubuntu ubuntu 4096 Oct 7 16:49 ..
-rw------- 1 ubuntu ubuntu 8908288 Oct 7 16:50 alpinesocat.tar
-rw------- 1 ubuntu ubuntu 556183552 Oct 7 16:49 netshoot.tar
The container image size for netshoot is 62x larger, which can significantly affect the speed of the test.
1138208 to
e43509f
Compare
18ecaa4 to
ccd74e7
Compare
|
Thank you so much for reviewing. I've changed the timeout duration and container image. cc. @christarazi |
ccd74e7 to
2a3aefb
Compare
|
@christarazi |
There was a problem hiding this comment.
Apologies for the delay.
This LGTM assuming that the multicast code only has a command-line level access to manipulate state. Ideally, moving forward the Cilium CLI connectivity tests are meant not to manipulate state of Cilium or run subsequent commands to retrieve state in the middle of the test, as it could be an additional source of flakes. For now, this is ok though.
a74d391 to
88110c2
Compare
Introduces Multicast connectivity test, working with netshoot container. Using socat for IGMP and UDP communication test. Receivers are running as Daemonset and a sender is running as a Deployment which has 1 replicaset. Signed-off-by: Yusho Yamaguchi <yusho.yamaguchi@sony.com>
|
@christarazi I understand that while I have separated the namespaces, it would be better to increase the level of isolation. However, at this point, I couldn't come up with a way to create a more isolated environment. I apologize Could you allow the remaining tests? |
|
/test |
|
@asauber I'm sorry. |
Introduces Multicast connectivity test, working with netshoot container.
Using socat for IGMP and UDP communication test.
Receivers are running as Daemonset and a sender is running as a Deployment which has 1 replicaset.
Operation was confirmed on the kind and kubeadm clusters.
This if follow up of cilium/cilium-cli#2615 .
In addtion, this PR is related to cilium/cilium-cli#2620 .
I want to implement a test scenario using multicast-subcommand after this is merged.
In addition, I'd like to put this test into GitHub CI.
related part of this command output (when 3 nodes)