maps/nat/stats: check the snat tuple direction as a bitmask. #34504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was doing a direct comparison agains the TUPLE_IN value. However this field is actually a flag bit set. The non IN/OUT values appear to only be used for ctmap, not snat so this should have no outcome on functionality, however this makes this code future proof in case this assumption ever changes. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
266c3e6 to
94aa4c6
Compare
julianwiedmann
approved these changes
Sep 10, 2024
|
/test |
markpash
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was doing a direct comparison agains the TUPLE_IN value. However this field is actually a flag bit set.
The non IN/OUT values appear to only be used for ctmap, not snat so this should have no outcome on functionality, however this makes this code future proof in case this assumption ever changes.