dnsproxy: fix error when sessionUDPFactory fails #33998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
mhofstetter
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
I've asked you @mhofstetter for review just to double check as I wasn't sure if you wanted to have separate error for some side-effect with ferr / err🤔? I couldn't find anything though.
No i'm not (no longer 😁 ) aware of such a special case. But thanks for asking!
LGTM - thanks for fixing this ✔️
Before, we were always printing nil from previous err rather than current ferr. Fixes: cilium#28163 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
77b19c3 to
666aa52
Compare
|
/test |
6 tasks
3 tasks
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28163
Before, we were always printing nil from previous err rather than current ferr.
I've asked you @mhofstetter for review just to double check as I wasn't sure if you wanted to have separate error for some side-effect with
ferr/err🤔? I couldn't find anything though.