Skip to content

gha: Add http client timeout in Ingress #33683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

gha: Add http client timeout in Ingress #33683

merged 1 commit into from
Jul 10, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jul 10, 2024 •
edited
Loading

Conformance Ingress job is running successfully for 10+ consecutive runs (i.e. 10x5 as each consists of 5 sub-jobs).

https://github.com/cilium/cilium/actions/runs/9870615332

Fixes: #31857

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 10, 2024
@sayboras sayboras added release-note/ci This PR makes changes to the CI. needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jul 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 10, 2024
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-flake-again branch from d1543fb to e45365b Compare July 10, 2024 03:47
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-flake-again branch from e45365b to b7ba8e0 Compare July 10, 2024 03:50
@sayboras
Copy link
Member Author

/test

@sayboras
gha: Add http client timeout in Ingress
16c74bc 
Relates: cilium/ingress-controller-conformance#3
Relates: #31857
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/ingress-flake-again branch from b7ba8e0 to 16c74bc Compare July 10, 2024 08:15
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review July 10, 2024 12:44
@sayboras sayboras requested review from a team as code owners July 10, 2024 12:44
@sayboras sayboras added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 342bb98 Jul 10, 2024
@sayboras sayboras deleted the pr/tammach/ingress-flake-again branch July 10, 2024 13:48
@giorio94 giorio94 mentioned this pull request Jul 15, 2024
Merged
27 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jul 15, 2024
@giorio94 giorio94 mentioned this pull request Jul 15, 2024
Merged
17 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Jul 15, 2024
@giorio94 giorio94 mentioned this pull request Jul 15, 2024
Merged
11 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Jul 15, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Jul 15, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Jul 15, 2024
Merged
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jul 18, 2024
This was referenced Aug 12, 2024
Merged
Merged
@cilium-release-bot cilium-release-bot bot mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

@viktor-kurchenko viktor-kurchenko Awaiting requested review from viktor-kurchenko viktor-kurchenko is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
cilium v1.14.14
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Ingress Conformance Test: timed out waiting for convergence
3 participants
@sayboras @mhofstetter @giorio94