ipsec: Deprecate global IPsec keys #33504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a single IPsec key for all IPsec tunnels is insecure. It was only preserved to allow for a smooth switch to per-tunnel keys. Per-tunnel keys have been released in v1.13, v1.14, and v1.15, so we can now deprecate the insecure alternative for v1.16. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
72cf1d8 to
2f9a943
Compare
|
/test |
julianwiedmann
approved these changes
Jul 3, 2024
Done at #33564. |
julianwiedmann
added a commit
that referenced
this pull request
Oct 8, 2024
The global IPsec key system is deprecated [0], prefer the new per-tunnel key system. [0] #33504 Reported-by: Marcel Zięba <marcel.zieba@isovalent.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added a commit
that referenced
this pull request
Oct 8, 2024
The global IPsec key system is deprecated [0], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs [1] addressed first. [0] #33504 [1] #32040 Reported-by: Marcel Zięba <marcel.zieba@isovalent.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
The global IPsec key system is deprecated [0], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs [1] addressed first. [0] #33504 [1] #32040 Reported-by: Marcel Zięba <marcel.zieba@isovalent.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Nov 28, 2024
The global IPsec key system is deprecated[^1], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs[^2] addressed first. [^1]: cilium/cilium#33504 [^2]: cilium/cilium#32040 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Nov 29, 2024
The global IPsec key system is deprecated[^1], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs[^2] addressed first. [^1]: cilium/cilium#33504 [^2]: cilium/cilium#32040 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 6, 2024
The global IPsec key system is deprecated[^1], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs[^2] addressed first. [^1]: cilium/cilium#33504 [^2]: cilium/cilium#32040 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 6, 2024
The global IPsec key system is deprecated[^1], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs[^2] addressed first. [^1]: cilium/cilium#33504 [^2]: cilium/cilium#32040 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a single IPsec key for all IPsec tunnels is insecure. It was only preserved to allow for a smooth switch to per-tunnel keys. Per-tunnel keys have been released in v1.13, v1.14, and v1.15, so we can now deprecate the insecure alternative for v1.16.