-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Attach to-wireguard to the tc egress of cilium_wg0 #33426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9840c37
to
a86eee6
Compare
a86eee6
to
b55bba8
Compare
Can't believe adding these trivial code leads to
Edit: I think compiling to-wireguard independently can solve the problem by getting rid of |
f19e66f
to
78e7a2a
Compare
78e7a2a
to
15e53b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bf2d8d5
to
46213e7
Compare
46213e7
to
a189b49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Just two smaller nits in case you need to rebase once more. Otherwise we can clean those up later.
This is to handle rev-DNAT when L7 ingress proxy is enabled with wireguard, nodeport, native routing, and KPR. Consider a pod-to-remote-nodeport connection, the reply packet will pass: from_lxc@veth -> redirected to L7 proxy -> from_host@cilium_host -> to_host@cilium_net -> to_netdev@eth0 -> redirected to cilium_wg0. This patch ensures the new attached to-wireguard@cilium_wg0 can do the necessary rev-DNAT. Fixes: cilium#32899 Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
BTW, with this PR merged, we can easily tackle:
From #23032. It will give us a few CPU cycles back 😎 |
MAX_WIREGUARD_OPTIONS and WIREGUARD_OPTIONS are set in a similar way to MAX_HOST_OPTIONS and HOST_OPTIONS, with ENABLE_IPSEC replaced by ENABLE_WIREGUARD. Signed-off-by: gray <gray.liang@isovalent.com>
The files are copied from bpf/complexity-tests/*/bpf_host/*.txt, followed by s/-DENABLE_IPSEC/-DENABLE_WIREGUARD/. Signed-off-by: gray <gray.liang@isovalent.com>
a189b49
to
2b3e1c6
Compare
/test |
This was added with cilium#33426. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This was added with #33426. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit 256684c ] This was added with cilium#33426. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 256684c ] This was added with cilium#33426. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
This is to handle rev-DNAT when L7 ingress proxy is enabled with wireguard, nodeport, native routing, and KPR.
Consider a pod-to-remote-nodeport connection via L7 ingress proxy, the reply packet will pass: from_lxc@veth -> redirected to L7 proxy -> from_host@cilium_host -> to_host@cilium_net -> to_netdev@eth0 -> redirected to cilium_wg0. This patch ensures the new attached to-wireguard@cilium_wg0 can do the necessary rev-DNAT in this case.
Fixes: #32899