Skip to content

gateway-api: Add service observable event handler #33352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

gateway-api: Add service observable event handler #33352

merged 2 commits into from
Oct 24, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jun 24, 2024 •
edited
Loading

This is to react based on events instead of relying on periodic sync.

Fixes: c3fcea2
Fixes: #33279

Testing

Testing was done as per below:

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 24, 2024
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras added area/CI Continuous Integration testing issue or flake release-note/bug This PR fixes an issue in a previous release of Cilium. feature/k8s-gateway-api labels Jun 24, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 24, 2024
@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from 1df6cc4 to b6e0124 Compare June 24, 2024 12:35
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from b6e0124 to 4e4f6bb Compare June 24, 2024 13:03
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from 4e4f6bb to cc848c1 Compare June 24, 2024 13:19
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from cc848c1 to e949528 Compare June 28, 2024 09:01
@sayboras
Copy link
Member Author

/ci-gateway-api

youngnick
youngnick reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, seems like it could definitely solve that Gateway API flakiness.

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch 2 times, most recently from c01eaa6 to 7dfd672 Compare July 10, 2024 14:12
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from 7dfd672 to ec40543 Compare July 23, 2024 05:12
@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from ec40543 to 01ec8f1 Compare July 30, 2024 13:34
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch 2 times, most recently from c306465 to ac966f8 Compare August 19, 2024 06:05
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch 2 times, most recently from eaed678 to fa07ea2 Compare August 19, 2024 10:52
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from fa07ea2 to 3e17ef4 Compare August 29, 2024 15:42
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from 3e17ef4 to 83aba75 Compare August 29, 2024 15:43
@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch 2 times, most recently from a9bdd39 to 104274f Compare October 20, 2024 23:00
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from 104274f to fb45fb9 Compare October 20, 2024 23:12
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 20, 2024
@sayboras
Copy link
Member Author

/test

@sayboras
gateway-api: Add service observable event handler
7c18374 
This is to react based on events instead of relying on periodic sync.

Fixes: c3fcea2
Fixes: #33279
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gha: Enable conformance-gateway-api in /test again
96a46d4 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/headless-service-flake branch from fb45fb9 to 96a46d4 Compare October 21, 2024 01:44
@sayboras
Copy link
Member Author

/test

@sayboras sayboras requested a review from youngnick October 21, 2024 04:00
@sayboras sayboras marked this pull request as ready for review October 21, 2024 04:01
@sayboras sayboras requested review from a team as code owners October 21, 2024 04:01
@sayboras sayboras requested review from mhofstetter and brlbil and removed request for mhofstetter October 21, 2024 04:01
pchaigno
pchaigno approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for CI pieces.

@pchaigno pchaigno removed the request for review from brlbil October 24, 2024 11:10
@pchaigno pchaigno enabled auto-merge October 24, 2024 11:10
@pchaigno pchaigno added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 9c61d26 Oct 24, 2024
276 checks passed
@pchaigno pchaigno deleted the pr/tammach/headless-service-flake branch October 24, 2024 22:35
@marseel marseel mentioned this pull request Feb 18, 2025
Merged
@marseel marseel mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake feature/k8s-gateway-api release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Conformance Gateway API: TestConformance/HTTPRouteServiceTypes
3 participants
@sayboras @pchaigno @youngnick