k8s: Fix usage of assert in TestWaitForCacheSyncWithTimeout #33139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestWaitForCacheSyncWithTimeout is relying on subtests, so a new assert
object should be derived from each subtest testing.T, in order to report
the failing one correctly.
Temporarily changing the code to force a failure in the "Not invoking
BlockWaitGroupToSyncResources should cause wait to succeed immediately"
case, it can be seen that no subtest is reported as failing:
--- FAIL: TestWaitForCacheSyncWithTimeout (0.00s)
--- PASS: TestWaitForCacheSyncWithTimeout/Waiting_for_no_resources_should_always_sync (0.00s)
--- PASS: TestWaitForCacheSyncWithTimeout/Not_invoking_BlockWaitGroupToSyncResources_should_cause_wait_to_succeed_immediately (0.00s)
--- PASS: TestWaitForCacheSyncWithTimeout/Should_timeout_due_to_watched_resource_exceeding_timeout (0.20s)
--- PASS: TestWaitForCacheSyncWithTimeout/Any_one_timeout_should_cause_error (0.60s)
--- PASS: TestWaitForCacheSyncWithTimeout/Should_complete_due_to_event_causing_timeout_to_be_extended_past_initial_timeout (0.70s)
While after this change the expected subtest is correctly reported as the
offending one:
--- FAIL: TestWaitForCacheSyncWithTimeout (0.00s)
--- PASS: TestWaitForCacheSyncWithTimeout/Waiting_for_no_resources_should_always_sync (0.00s)
--- FAIL: TestWaitForCacheSyncWithTimeout/Not_invoking_BlockWaitGroupToSyncResources_should_cause_wait_to_succeed_immediately (0.00s)
--- PASS: TestWaitForCacheSyncWithTimeout/Should_timeout_due_to_watched_resource_exceeding_timeout (0.20s)
--- PASS: TestWaitForCacheSyncWithTimeout/Any_one_timeout_should_cause_error (0.60s)
--- PASS: TestWaitForCacheSyncWithTimeout/Should_complete_due_to_event_causing_timeout_to_be_extended_past_initial_timeout (0.70s)
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
nathanjsweet
approved these changes
Jun 14, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestWaitForCacheSyncWithTimeout is relying on subtests, so a new assert object should be derived from each subtest testing.T, in order to report the failing one correctly.
Temporarily changing the code to force a failure in the
Not invoking BlockWaitGroupToSyncResources should cause wait to succeed immediatelycase, it can be seen that no subtest is reported as failing:While after this change the expected subtest is correctly reported as the offending one: