Skip to content

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 13, 2024

See the second patch description for details.

@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Jun 13, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title 1.16 bpf host l2 proto bpf: extract ethertype in to-netdev / to-overlay just once Jun 13, 2024
@julianwiedmann julianwiedmann marked this pull request as ready for review June 13, 2024 10:11
@julianwiedmann julianwiedmann requested review from a team as code owners June 13, 2024 10:11
@julianwiedmann julianwiedmann requested a review from brb June 13, 2024 10:11
@julianwiedmann julianwiedmann force-pushed the 1.16-bpf-host-l2-proto branch from f72643c to 7609baa Compare June 13, 2024 12:26
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann force-pushed the 1.16-bpf-host-l2-proto branch from 7609baa to e7c8cdc Compare June 14, 2024 11:38
@julianwiedmann julianwiedmann requested a review from a team as a code owner June 14, 2024 11:38
@julianwiedmann julianwiedmann requested a review from rgo3 June 14, 2024 11:38
@julianwiedmann julianwiedmann marked this pull request as draft June 14, 2024 11:39
In preparation for a subsequent patch.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Remove some duplicated logic.

Ideally we would only do the extraction if at least *one* feature is
enabled that actually requires the ethertype. But managing these
dependencies doesn't seem worth the hassle.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.16-bpf-host-l2-proto branch from e7c8cdc to 18114a4 Compare June 14, 2024 11:39
@julianwiedmann julianwiedmann removed request for a team and rgo3 June 14, 2024 11:39
@julianwiedmann julianwiedmann marked this pull request as ready for review June 14, 2024 11:39
@julianwiedmann
Copy link
Member Author

/test

Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julianwiedmann julianwiedmann enabled auto-merge June 14, 2024 12:28
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
Merged via the queue into cilium:main with commit 736af68 Jun 14, 2024
@julianwiedmann julianwiedmann deleted the 1.16-bpf-host-l2-proto branch June 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants